tinkerbell / pbnj

Service for interacting with BMCs
Apache License 2.0
109 stars 37 forks source link

Update ipmitool commit in Dockerfile to 1.8.19 #158

Closed turegano-equinix closed 10 months ago

turegano-equinix commented 10 months ago

The new version include bug fixes that address issues present in the previous release, leading to a more stable and reliable tool

https://github.com/ipmitool/ipmitool/blob/master/ChangeLog

Description

It is going to update the ipmitool

Why is this needed

https://github.com/ipmitool/ipmitool/issues/163

Fixes: #

How Has This Been Tested?

I compiled the code in a Docker container and ran it against physical hardware.

How are existing users impacted? What migration steps/scripts do we need?

It fixes bugs, no additional changes are required.

Checklist:

I have:

codecov[bot] commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5660359) 81.87% compared to head (35c0fbe) 82.29%. Report is 4 commits behind head on main.

Files Patch % Lines
grpc/rpc/bmc.go 91.30% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #158 +/- ## ========================================== + Coverage 81.87% 82.29% +0.42% ========================================== Files 9 9 Lines 491 514 +23 ========================================== + Hits 402 423 +21 - Misses 75 76 +1 - Partials 14 15 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joelrebel commented 10 months ago

@turegano-equinix A rebuild was successful here, now you just have to fix the DCO check

joelrebel commented 10 months ago

FTR, this build was tested on a variety of hardware internally and is considered to be functioning as expected.