Add NMI Support - Githubissues

coffeefreak101 commented 8 months ago

This change adds support for issuing an NMI from the BMC, which is helpful for interrupting unresponsive hosts.

Add SendNMI method to the gRPC diagnostic service, and client.
The version of bmclib is updated to use the new SendNMI code.
All of the protobuf go files seem to have changed due to minior formatting changes and comments from a newver version of protoc.

joelrebel commented 8 months ago

At first glance, this looks okay to me

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 79.36%. Comparing base (914dcc1) to head (a47e580).

Files	Patch %	Lines
grpc/rpc/diagnostic.go	0.00%	19 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #161 +/- ## ========================================== - Coverage 82.29% 79.36% -2.94% ========================================== Files 9 9 Lines 514 533 +19 ========================================== Hits 423 423 - Misses 76 95 +19 Partials 15 15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tinkerbell / pbnj

Add NMI Support #161

Codecov Report