investigate changing over to bmclib

mmlb commented 4 years ago

https://github.com/bmc-toolbox/bmclib

mrmrcoleman commented 4 years ago

Can we help here @mmlb ?

mmlb commented 4 years ago

@mrmrcoleman for sure, this is just a TODO type issue. Any one can pick up.

joelrebel commented 4 years ago

Hey! as one of the maintainers of the bmclib project, I'd be interested to help with this integration, having run bmclib in production for a while, theres a few areas, where bmclib could improve and I'd be keen on fixing them, to name a few,

Add Context support - various methods in the library block indefinitely until the HTTPS/SSH dialers/transport timeout https://github.com/bmc-toolbox/bmclib/blob/master/devices/interfaces.go#L10
Less opinionated BMC methods - certain hardware actions were found to be more reliable over SSH, this can be changed to allow the caller to set the method of access (HTTPS/SSH/IPMI/Redfish) https://github.com/bmc-toolbox/bmclib/blob/master/providers/dell/idrac9/actions.go#L37
The ScanAndConnect() method acts as an entry point to probe the vendor/model of hardware, although if the HTTPS interface is down for whatever reason (crappy BMCs) this method will fail, here the caller could be given the option to set the method of access - HTTPS/SSH/IPMI/Redfish https://github.com/bmc-toolbox/bmclib/blob/master/discover/discover.go#L26

Hopefully this gives you an idea of where the bmclib project needs work and saves some evaluation time, it would be ideal to fix these before PBNJ integrates :)

jacobweinstock commented 3 years ago

going to close this as we have bmclib in full use now!

tinkerbell / pbnj

investigate changing over to bmclib #3