tinkerbell / playground

Example deployments of the Tinkerbell Stack for use as playground environments
Apache License 2.0
131 stars 87 forks source link

docker-compose quickstart breaks with ERROR: Invalid interpolation format for "tls-gen" option in service "services": "${FACILITY:-onprem}" #118

Closed dch closed 1 year ago

dch commented 2 years ago

Expected Behaviour

$ docker-compose up -d
Creating network "compose_default" with the default driver
Creating volume "compose_postgres_data" with default driver
Creating volume "compose_certs" with default driver
Creating volume "compose_auth" with default driver
Pulling tls-gen (cfssl/cfssl:)...
latest: Pulling from cfssl/cfssl
* woot * ** party parrot **

Current Behaviour

$ docker-compose up -d
ERROR: Invalid interpolation format for "tls-gen" option in service "services": "${FACILITY:-onprem}"

Possible Solution

I think the precise version docker-compose needs to be specified. 2.x is already public, 1.26 is too old, and 1.29.2 works for me.

$ curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose

Steps to Reproduce (for bugs)

$ curl -L "https://github.com/docker/compose/releases/download/1.26/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose

Context

I was trying the simplest way to get to a running tinkerbell setup, assuming that docker-compose might be a good starting point.

Your Environment

using an ubuntu 20.04.3 LTS VM.

ubuntu vm

n/a

jacobweinstock commented 2 years ago

Hey @dch, thanks for reporting this. Were you following this guide by chance? https://github.com/tinkerbell/sandbox/blob/main/docs/quickstarts/COMPOSE.md It does mention a docker-compose version requirement, but maybe we need to present that in a different way.

dch commented 2 years ago

Yea a bit of this and perusing the vagrantfile from libvirt approach

On Thu, 2 Dec 2021, at 17:49, Jacob Weinstock wrote:

Hey @dch https://github.com/dch, thanks for reporting this. Were you following this guide by chance? https://github.com/tinkerbell/sandbox/blob/main/docs/quickstarts/COMPOSE.md It does mention a docker-compose version requirement, but maybe we need to present that in a different way.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tinkerbell/sandbox/issues/118#issuecomment-984807752, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACFNUBEZKTRVA7QACQDNKDUO6PSBANCNFSM5I5LHOFA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jacobweinstock commented 2 years ago

Hey @dch. Based on your experience here, would you be willing to provide any feedback on what we could do to make the docker-compose version requirement more apparent?

Akucina commented 2 years ago

I had similar error prompt while running: docker-compose ps

Later, realized that I did not run: cd /vagrant/compose first.

/vagrant is Synced Folder defined in Vagrant file:

provisioner.vm.synced_folder '../', '/vagrant'