Convert to debian and allow passing a bridge interface

tinkerbell / playground

Example deployments of the Tinkerbell Stack for use as playground environments

Apache License 2.0

126 stars 85 forks source link

Convert to debian and allow passing a bridge interface #153

Closed ClashTheBunny closed 1 year ago

ClashTheBunny commented 1 year ago

Description

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

mmlb commented 1 year ago

Hey @ClashTheBunny thanks for the PR. I like the bridge patch and most of the debian one too, but I don't want the change from ubuntu -> debian nor the fetching of the image in the docker-compose.yaml (no need to download if not going to be used). Can you drop those bits and instead add a section in the README about different OS images and add your debian changes there?

mmlb commented 1 year ago

oh wait you didn't change from ubuntu -> debian! (still haven't had my espresso :smile:)

ClashTheBunny commented 1 year ago

Sorry, I too have not had my coffee, this was meant to be a draft still! :-D

I'm working on the documentation for both the bridge config and how to select a different OS. I did mistakenly include debian in the default .env file, so I do need to change that back...

mmlb commented 1 year ago

hehe no worries we'll just forget it wasn't draft and that I made any comments at all ;)

chrisdoherty4 commented 1 year ago

Closing as stale. Feel free to re-open as needed.