search

tinkerbell / playground

Example deployments of the Tinkerbell Stack for use as playground environments
Apache License 2.0
132 stars 87 forks source link

Minor s/2004/2204/ #161

Closed stappersg closed 2 years ago

stappersg commented 2 years ago

Description

Substituted a 2004 into 2204.

Why is this needed

Avoiding Oh old documentation, let it rot further

Fixes: __

stappersg commented 2 years ago

Today I learnt that git commit --amend --signoff --no-edit has to done before a git push, that you can't do a --signoff in git commit --amend after git push of the original commit.

Closing this merge request, because there is now #162.

Regards Geert Stappers Who also closed MR #160

chrisdoherty4 commented 2 years ago

@stappersg That's not quite true. The --signoff addition will re-write the commit and you can force push that commit with git push -f re-writing the history for your branch. Generally you only want to do that on branches you're the sole contributor on. If there are others, you need to coordinate carefully hence we never do this for main.