search

tinkerbell / playground

Example deployments of the Tinkerbell Stack for use as playground environments
Apache License 2.0
127 stars 85 forks source link

Fix a bug: docker-compose >= 1.28: "host" network_mode is incompatible with port_bindings #95

Closed HoKim98 closed 2 years ago

HoKim98 commented 2 years ago

Description

Fixed a bug: "host" network_mode is incompatible with port_bindings This minor bug seems to occur when docker-compose >= 1.28. I tested on ArchLinux with docker-compose = 1.29.2.

note: https://forums.docker.com/t/docker-errors-invalidargument-host-network-mode-is-incompatible-with-port-bindings/103492/3

Why is this needed

Fix a bug: docker-compose >= 1.28: "host" network_mode is incompatible with port_bindings

Fixes: #

mmlb commented 2 years ago

Hey @kerryeon this looks fine and I'm ready to merge, but we need you to verify that you've read & understand the DCO.

jacobweinstock commented 2 years ago

Hey @kerryeon, #90 just landed and has changed the sandbox significantly. Would you mind having a look at the changes and confirm if this change is still something you'd like to see?

HoKim98 commented 2 years ago

Hello @jacobweinstock, it seems that the problem is gone on #90.