search

tinkerbell / playground

Example deployments of the Tinkerbell Stack for use as playground environments
Apache License 2.0
131 stars 87 forks source link

Use rsync for vagrant-libvirt sync_folder: #98

Closed jacobweinstock closed 3 years ago

jacobweinstock commented 3 years ago

Description

The NFS type for synced_folder requires nfsd to be installed and running on a machine for vagrant up to be successful. nfs was used so that folders were r/w bidirectionally. I don't really think there is a need for this bidirectional functionality. Moving to rsync should make this work more universally.

Why is this needed

Issue https://github.com/tinkerbell/sandbox/issues/97 reported. Moving away from nfs for vagrant libvirt synced_folders should work more universally.

Fixes: #97

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

MikePadge commented 3 years ago

Bringing this over here since I closed the issue

Hey @MikePadge, sorry I'm not following. The PR #98 breaks the docker-compose? That PR doesn't use NFS anymore.

I thought the docker-compose files were expecting the nfs mounts to be available in the vagrant box, but I don't see nfs being used for volumes in these compose files. So I dont' know why they're breaking

Annd that being said, it looks like with nfsd I'm getting the same secondary errors with the containers as rsync. So I'll go ahead and collect that info and open a new issue.