tinkerbell / rufio

Kubernetes Controller for BMC Interactions
Apache License 2.0
37 stars 16 forks source link

Update API with per provider opts: #143

Closed jacobweinstock closed 1 year ago

jacobweinstock commented 1 year ago

Description

This enables customization per provider. For example, redfish port, ipmitool cipher suite.

Why is this needed

Once implemented will resolve #89 and #103

Fixes:

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

codecov[bot] commented 1 year ago

Codecov Report

Merging #143 (2edcded) into main (bda0103) will decrease coverage by 0.22%. The diff coverage is 50.00%.

:exclamation: Current head 2edcded differs from pull request most recent head 950d970. Consider uploading reports for the commit 950d970 to get more accurate results

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   62.03%   61.82%   -0.22%     
==========================================
  Files           4        4              
  Lines         353      351       -2     
==========================================
- Hits          219      217       -2     
  Misses        100      100              
  Partials       34       34              
Files Changed Coverage Δ
controllers/machine.go 79.77% <50.00%> (-0.45%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jacobweinstock commented 1 year ago

Hey Fellas, @chrisdoherty4 , @joelrebel , @pokearu . When you have some cycles, I'd appreciate a review. Please and thank you!

jacobweinstock commented 1 year ago

@mergifyio queue

mergify[bot] commented 1 year ago

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at *357b551877f7002bea2def7607ccd1c73c9fa4cc*