tinkerbell / rufio

Kubernetes Controller for BMC Interactions
Apache License 2.0
36 stars 16 forks source link

Implement provider options #154

Closed jacobweinstock closed 11 months ago

jacobweinstock commented 11 months ago

Description

This implements the provider options now available in the connection crd for machine and task controllers. Also, updated dependencies for controller-runtime and kubernetes client libraries.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

codecov[bot] commented 11 months ago

Codecov Report

Merging #154 (4023da7) into main (a9b033b) will increase coverage by 1.35%. Report is 10 commits behind head on main. The diff coverage is 67.66%.

:exclamation: Current head 4023da7 differs from pull request most recent head a5ed4b5. Consider uploading reports for the commit a5ed4b5 to get more accurate results

@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   61.82%   63.17%   +1.35%     
==========================================
  Files           4        5       +1     
  Lines         351      478     +127     
==========================================
+ Hits          217      302      +85     
- Misses        100      137      +37     
- Partials       34       39       +5     
Files Coverage Δ
controller/job.go 53.96% <ø> (ø)
controller/kube.go 95.65% <95.65%> (ø)
controller/task.go 67.93% <87.50%> (ø)
controller/machine.go 78.88% <88.88%> (ø)
controller/client.go 48.14% <48.14%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jacobweinstock commented 11 months ago

@mergifyio queue

mergify[bot] commented 11 months ago

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.
jacobweinstock commented 11 months ago

@mergifyio refresh

mergify[bot] commented 11 months ago

refresh

✅ Pull request refreshed

jacobweinstock commented 11 months ago

@mergifyio queue

mergify[bot] commented 11 months ago

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.
jacobweinstock commented 11 months ago

@mergifyio refresh

mergify[bot] commented 11 months ago

refresh

✅ Pull request refreshed

jacobweinstock commented 11 months ago

@Mergifyio unqueue

mergify[bot] commented 11 months ago

unqueue

☑️ The pull request is not queued

jacobweinstock commented 11 months ago

@mergifyio queue

mergify[bot] commented 11 months ago

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.