tinkerbell / rufio

Kubernetes Controller for BMC Interactions
Apache License 2.0
36 stars 16 forks source link

Create a manager cache only when a ns is specified: #156

Closed jacobweinstock closed 11 months ago

jacobweinstock commented 11 months ago

Description

A cache with a "" namespace causes reconcile errors: "unable to get: namespace/machine because of unknown namespace for the cache"

With this change if the namespace is "" we use the default behavior of the manager which is to watch and list all namespaces.

I believe this was the behavior before we upgrade the controller runtime.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

codecov[bot] commented 11 months ago

Codecov Report

Merging #156 (c8ec298) into main (1065313) will not change coverage. The diff coverage is n/a.

:exclamation: Current head c8ec298 differs from pull request most recent head b24fff5. Consider uploading reports for the commit b24fff5 to get more accurate results

@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   63.17%   63.17%           
=======================================
  Files           5        5           
  Lines         478      478           
=======================================
  Hits          302      302           
  Misses        137      137           
  Partials       39       39           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more