search

tinkerbell / rufio

Kubernetes Controller for BMC Interactions
Apache License 2.0
32 stars 15 forks source link

task connection `authSecretRef` namespace does not fallback to the namespace the task is in #187

Open peterwillis opened 5 months ago

peterwillis commented 5 months ago

I noticed that the namespace field on the authSecretRef is required, and if not set falls back to the default namespace. With a small amount of guidance I am happy to submit a PR that makes it fall back to using the namespace the task is in.

https://github.com/tinkerbell/rufio/blob/ce6d290f918a1773debb71bcf1474c6288bff0ee/controller/kube.go#L19

chrisdoherty4 commented 5 months ago

@peterwillis Thanks. Tweaking this would require populating the namespace before submitting to the resolveAuthSecretRef() func at both https://github.com/tinkerbell/rufio/blob/main/controller/machine.go#L112 and https://github.com/tinkerbell/rufio/blob/main/controller/task.go#L107.