Remove list permission for secrets:

jacobweinstock commented 2 months ago

Description

This is unneeded and a potential security risk.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.91%. Comparing base (81557c0) to head (36b127c).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #228 +/- ## ======================================= Coverage 47.91% 47.91% ======================================= Files 11 11 Lines 1081 1081 ======================================= Hits 518 518 Misses 508 508 Partials 55 55 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jacobweinstock commented 2 months ago

List permission is needed for the caching mechanism of controller runtime. See: https://github.com/tinkerbell/charts/pull/105

tinkerbell / rufio