tinkerbell / rufio

Kubernetes Controller for BMC Interactions
Apache License 2.0
39 stars 16 forks source link

Handle potential nil pointer panic: #274

Closed jacobweinstock closed 1 week ago

jacobweinstock commented 1 week ago

Description

It possible for opts (*BMCOptions) in NewClientFunc to be nil and cause a panic.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 46.80%. Comparing base (e9d50f1) to head (75ad68a). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
controller/client.go 0.00% 13 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #274 +/- ## ========================================== - Coverage 46.97% 46.80% -0.18% ========================================== Files 11 11 Lines 1356 1361 +5 ========================================== Hits 637 637 - Misses 661 666 +5 Partials 58 58 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: