chrisdoherty4 commented 2 years ago

Build docker images for Rufio on the CI and push to quay.io.

This currently only supports amd64. We can expand to other builds by leveraging Go's cross compilation feature for speed as we've observed, in other projects, the cross docker build to be quite slow.

Closes #26

codecov-commenter commented 2 years ago

Codecov Report

Merging #39 (e202952) into main (2faddf0) will not change coverage. The diff coverage is n/a.

:exclamation: Current head e202952 differs from pull request most recent head 89ec5cd. Consider uploading reports for the commit 89ec5cd to get more accurate results

@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   18.98%   18.98%           
=======================================
  Files           4        4           
  Lines         316      316           
=======================================
  Hits           60       60           
  Misses        249      249           
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2faddf0...89ec5cd. Read the comment docs.

displague commented 2 years ago

We have a self-hosted arm-64 runner, is this an architecture we can add now? Can we create issues to address any architectures that we generally cover that we would not be covering in this PR?

chrisdoherty4 commented 2 years ago

I intended on doing the other arch separately because I want to play with GitHub actions some and adjust the Makefile so we can lever cross compilation as it's faster than the Docker builds with emulation.

Assuming that works, I'll raise a ticket.

@displague

chrisdoherty4 commented 2 years ago

@displague Raised https://github.com/tinkerbell/rufio/issues/41

tinkerbell / rufio

Build images and push to quay.io #39

Codecov Report