Open chrisdoherty4 opened 2 years ago
When Rufio times out a task it returns an error from the reconciliation request resulting in an unnecessary requeue.
Instead, we expect the controller to patch the status, log the error and return nothing preventing the requeue.
This isn't hugely impactful as the controller identifies the task as failed and noops on the subsequent reconciliation. See https://github.com/tinkerbell/rufio/blob/main/controllers/task_controller.go#L133
When Rufio times out a task it returns an error from the reconciliation request resulting in an unnecessary requeue.
Instead, we expect the controller to patch the status, log the error and return nothing preventing the requeue.
This isn't hugely impactful as the controller identifies the task as failed and noops on the subsequent reconciliation. See https://github.com/tinkerbell/rufio/blob/main/controllers/task_controller.go#L133