search

tinkerbell / tink

Workflow Engine for provisioning Bare Metal
https://tinkerbell.org
Apache License 2.0
913 stars 134 forks source link

Let's adopt Bors to merge PRs #145

Closed grahamc closed 4 years ago

grahamc commented 4 years ago

The "require being up to date with master before merging" restriction is a good idea, but makes it really tricky to merge PRs. We could get this same benefit but with automation and without the race to merge a PR by using bors: https://bors.tech/

All we have to do is click enable here: https://github.com/apps/bors and read https://bors.tech/documentation/getting-started/

I propose adding this to all the tinkerbell repos.

dustinmiller commented 4 years ago

This looks cool :+1:

gauravgahlot commented 4 years ago

@grahamc Can we also look at Mergify as an alternative to Bors? It uses a configuration file (like this one) and allows us to have customization that best suits our needs.

grahamc commented 4 years ago

Absolutely. Any chance you could have a merging config file PR for Standup today?

On Thu, Jun 4, 2020, at 9:08 AM, Gaurav Gahlot wrote:

@grahamc https://github.com/grahamc Can we also look at Mergify https://mergify.io/ as an alternative to Bors? It uses a configuration file (like this one https://github.com/infracloudio/botkube/blob/develop/.mergify.yml) and allows us to have customization that best suits our needs.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tinkerbell/tink/issues/145#issuecomment-638835741, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASXLEIK3PB3AIXEPFFV5LRU6MDFANCNFSM4NQ2O5PQ.

grahamc commented 4 years ago

Mergify* of course. Autocorrect is a bear.

On Thu, Jun 4, 2020, at 9:47 AM, Graham Christensen wrote:

Absolutely. Any chance you could have a merging config file PR for Standup today?

On Thu, Jun 4, 2020, at 9:08 AM, Gaurav Gahlot wrote:

@grahamc https://github.com/grahamc Can we also look at Mergify https://mergify.io/ as an alternative to Bors? It uses a configuration file (like this one https://github.com/infracloudio/botkube/blob/develop/.mergify.yml) and allows us to have customization that best suits our needs.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tinkerbell/tink/issues/145#issuecomment-638835741, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASXLEIK3PB3AIXEPFFV5LRU6MDFANCNFSM4NQ2O5PQ.

gauravgahlot commented 4 years ago

Done. #148