search

tinkerbell / tink

Workflow Engine for provisioning Bare Metal
https://tinkerbell.org
Apache License 2.0
913 stars 134 forks source link

Why is git a pre-requirement in setup.sh? #172

Closed rgl closed 4 years ago

rgl commented 4 years ago

Why is git a pre-requirement in setup.sh?

rgl commented 4 years ago

Oh we now need to git clone the tink repo? The setup.sh no longer is downloaded from the internet has described at https://github.com/tinkerbell/tink/blob/master/docs/setup.md?

mrmrcoleman commented 4 years ago

The setup experience is being changed and the docs will follow shortly afterwards.

On Tue, 16 Jun 2020 at 22:04, Rui Lopes notifications@github.com wrote:

Oh we now need to git clone the tink repo? The setup.sh no longer is downloaded from the internet has described at https://github.com/tinkerbell/tink/blob/master/docs/setup.md?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tinkerbell/tink/issues/172#issuecomment-645010914, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR3GYTTQYIGP2MY6YODIALRW7M5VANCNFSM4N76OCCQ .

--

Mark Coleman +44(0)7367462394

rgl commented 4 years ago

Got it working at https://github.com/rgl/rpi-tinkerbell-vagrant/tree/wip-upgrade-tinkerbell. Some other day I will have to test whether the rpi provisioning still works.

I have to say that the installation is now simpler to understand as the dependencies are explicit (curl, git, docker, docker-compose) and to start tinkerbell we can just use docker-compose up --detach. Nicely done!

And hurrah to being able to directly use the docker logs command! I do not miss the heavyweight of ELK in the default setup.

The only thing that was unexpected was the need to pre-create the directory at /etc/docker/certs.d/$provisioner_ip_address (see https://github.com/rgl/rpi-tinkerbell-vagrant/commit/7b381fa4edb7f36d9269a51596639672f3316487#diff-f9e2dd117f9eb399ee41b4f867143dc2R23).

mrmrcoleman commented 4 years ago

I'm glad you find the new installation simpler to understand that was the idea.

@grahamc May be able to address your certs concern.

grahamc commented 4 years ago

Git as a requirement: good catch. It isn't needed anymore. I dropped it in https://github.com/tinkerbell/tink/pull/173

Certs directory: I hit this yesterday and forgot to open a PR. I fix it in https://github.com/tinkerbell/tink/pull/174

I'm glad the docker logs option is good for you! Hopefully it saves a lot of time for everybody. Also, the updated docs are indeed coming.