tinkerbell / tink

Workflow Engine for provisioning Bare Metal
https://tinkerbell.org
Apache License 2.0
919 stars 134 forks source link

Remove facilty params/concept from all of tinkerbell #389

Closed mmlb closed 1 month ago

mmlb commented 3 years ago

Facility concept is very EM specific and as such should be removed. I'm pretty sure we don't need it as any current use of it would be better served with explicit URLs instead of plugging facility into a hard code string "template".

gianarb commented 3 years ago

I had quick look at it and this is a bc break I think, the cert endpoint will break because it requires a facility for example.

So, how do we want to proceed? bc break?

@mmlb

jacobweinstock commented 1 month ago

facility has its use but this issue isn't up to date with the code base anymore.