prettier is required by kube.mk

displague commented 2 years ago

prettier is required by kube.mk, preventing make generate from succeeding when prettier is not installed.

Expected Behaviour

Most of the required tools for linting and code generation are installed as needed. Prettier should be automatically installed.

Current Behaviour

make generate failed if it is not installed.

Possible Solution

Add a prettier task to one of the Makefiles. Depend on this task for generate-manifests.

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Context

Your Environment

Operating System and version (e.g. Linux, Windows, MacOS):
How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:
Link to your project or a code example to reproduce issue:

chrisdoherty4 commented 1 year ago

It seems like the intent is for people to use NixOS so it should be available. NixOS is painful and we've talked about getting rid of it entirely. Since the files being 'prettified' are generated, I've opted for a simple life and just removed prettier in #650 as I couldn't get past the CI checks without setting up and understanding in some capacity NixOS, which I don't want to do.

chrisdoherty4 commented 1 year ago

Due to other issues I had to revert removing prettier. Lets move to get rid of it soon, particularly for generated files.

Once removed we can close this issue.

tinkerbell / tink