codecov[bot]
commented
3 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 28.02%. Comparing base (
81fcfe6) to head (45f163e).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #958 +/- ## ======================================= Coverage 28.02% 28.02% ======================================= Files 70 70 Lines 3486 3486 ======================================= Hits 977 977 Misses 2447 2447 Partials 62 62 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This default value doesn't make sense from a holistic point of view. Apply a Hardware object to a cluster doesn't by default indicate the hardware is in a provisioning state and we should not assume this with a default value. It was added as part of some CAPT refactoring. https://github.com/tinkerbell/tink/pull/669 If CAPT needs this state then the responsibility is on CAPT to set this. Also, this field is no longer used by Smee or CAPT.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: