tinkerbell / tink

Workflow Engine for provisioning Bare Metal
https://tinkerbell.org
Apache License 2.0
924 stars 133 forks source link

action images are not available publicly yet ? #98

Closed sokoow closed 4 years ago

sokoow commented 4 years ago

I'm trying to pull your action images, but I keep getting this:

root@ubuntu:/home/student# docker pull quay.io/tinkerbell/ubuntu:base
Error response from daemon: unauthorized: access to the requested resource is not authorized
root@ubuntu:/home/student# docker pull quay.io/tinkerbell/disk-wipe:v3
Error response from daemon: unauthorized: access to the requested resource is not authorized
root@ubuntu:/home/student# docker pull quay.io/tinkerbell/disk-partition:v3
Error response from daemon: unauthorized: access to the requested resource is not authorized

Are they public yet ?

parauliya commented 4 years ago

Action images are not supposed to be public. We are hosting a private docker registry on provisioner machine on which action images will be pushed after creating those. When the workflow starts running, it will pull those images from the private registry and start that particulat action.

sokoow commented 4 years ago

Yeah, but I still don't get it. So, in your docs you refer to doing something like this:

docker push 192.168.1.1/tink-worker
docker push 192.168.1.1/ubuntu:base
docker push 192.168.1.1/disk-wipe:v3
docker push 192.168.1.1/disk-partition:v3
docker push 192.168.1.1/install-root-fs:v3
docker push 192.168.1.1/install-grub:v3

which is indeed pushing action images to my own private local registry, fine. But, where do I get these images from ? If I just can't do docker pull quay.io/tinkerbell/disk-partition:v3, where are they coming from ?

gauravgahlot commented 4 years ago

Hey @sokoow, can you please point me to the document? It definitely needs to be corrected. This is because the above images were part of a PoC and never made public. The document must have been updated in time. I'm really sorry for the confusion and trouble.

parauliya commented 4 years ago

@sokoow Just FYI , Action images are generated by the user and pushed to <private registry>. As @gauravgahlot mentioned docs are not updated because these images are generated by us for our PoC and never made public. Please provide the link of the document you are referring to.

sokoow commented 4 years ago

it's referred here: https://tinkerbell.org/troubleshooting/

Also here you refer to a template that installs ubuntu with these steps: https://tinkerbell.org/concepts/

So, you are not planning to release a basic ubuntu installer ? Or you have to clean it up first ? I don't see how community will potentially figure that part out without viable examples, and that might impact your project a bit negatively :/

gauravgahlot commented 4 years ago

Thank you @sokoow There's a PR with documentation updates where I have cleaned the troubleshooting page.

The template in the concepts section is just an example to describe how a user can define their template and also leverage volumes, environment variables in a template.

I understand your concern. We are updating the documentation to give correct examples and Ubuntu provisioning will probably be the first.

sokoow commented 4 years ago

awesome - this will change a lot on the open source provisioning market

gauravgahlot commented 4 years ago

I really look forward to your feedback once things are more stable. Can you please close the issue, unless there is something you would like to ask? Thanks again @sokoow

sokoow commented 4 years ago

cool, thanks