tinkerhub.org/learn gives 404

[nikiljos]

https://tinkerhub.org/learn Has this link changed?

[LunaticHacker]

Probably related to changing the org name

[nikiljos]

Any new link?

[LunaticHacker]

github pages deployed to this link, but all hrefs and resources are failing to load because of hardcoded values, looks like custom domain settings are cleared in that repo we need to update that.

[nikiljos]

Was tinkerhub.org CNAME records updated to the new github pages URL? Seems like tinkerhub.org/learn is pointing to https://tinkerhub-org.github.io/learn instead of https://tinkerhub.github.io/learn

[LunaticHacker]

@GopikrishnanSasikumar can you take a look at this?

[nikiljos]

If we change the resource links in https://github.com/tinkerhub/learn to relative links instead of hard coding links to tinkerhub.org/learn we can view the site perfectly in https://tinkerhub.github.io/learn/ .... See it working fine with relative links in my forked repo https://github.com/nikiljos/learn and preview my fork live in https://tinkerhub-learn.netlify.app/

[nikiljos]

Also couldn't we make future github actions production builds use the relative links instead of tinkerhub.org/learn links?

[nikiljos]

If this idea works fine, Check out this PR https://github.com/tinkerhub/learn/pull/1

[LunaticHacker]

• No that files shouldn't be edited manually.
• The URL is hardcoded in the config file .
• Ideally someone with admin access should fix this by fixing custom URL problem.
• The only thing we should do is updating the workflow

[nikiljos]

But isn't it better to be having relative URLs instead of hardcoding the domain..... what if we want to change it to learn.tinkerhub.org in future. Also if we change the existing ones manually to relative URLs and handle the future ones with github actions itself wont the portal work fine

[LunaticHacker]

You can just change to baseUrl ="/" in the config and rebuild instead of manually changing everything,

[nikiljos]

That's cool.... I just did it when i saw learning path down for long..... You can close that PR 😀

[LunaticHacker]

FYI i dont have access to repos to close or merge PRs you should ping someone with admin access if you want this issue fixed

[rohittp0]

All sorted Learning Paths now working. I am closing this issue. Please reopen if any further discussion is needed.

[LunaticHacker]

This is still 404

[rohittp0]

This is still 404

Yeah, it has not yet been linked to tinkerhub.org domain. Currently working on it. It will be done ASAP

[gautamkrishnar]

@rohittp0 instead of setting https://tinkerhub.github.io/ you could've used the old domain istelf.

I guess the problem here is with the repo name of https://github.com/tinkerhub/tinkerhub-org.github.io. You should rename this repo to https://github.com/tinkerhub/tinkerhub.github.io. Once you are done with this change please try hitting /learn route, it should work fine if we are still using the github pages. If its working please revert the change of domain you had made here https://github.com/tinkerhub/TinkerHub-Learning-Paths/commit/016ac5b837cb7921ec659b9d3389602e7adfd10e in the code.

[nikiljos]

Still what I can't understand is why can't these be relative URLs ? Won't it solve any such problems in the future?

[gautamkrishnar]

@rohittp0 its not anything related to code. This is just due to the recent change in our org url. Using absoulute url is entirley ok. We wont change org username that often so its ok to have absolute urls.

[gautamkrishnar]

Inorder to make the urls relative we need to do some code change. I will take a look at it sometime later @nikiljos

[rohittp0]

@rohittp0 instead of setting https://tinkerhub.github.io/ you could've used the old domain istelf.

I guess the problem here is with the repo name of https://github.com/tinkerhub/tinkerhub-org.github.io. You should rename this repo to https://github.com/tinkerhub/tinkerhub.github.io. Once you are done with this change please try hitting /learn route, it should work fine if we are still using the github pages. If its working please revert the change of domain you had made here 016ac5b in the code.

Thanks to @gautamkrishnar everything is back to working.

https://tinkerhub.github.io/learn/ This link will no longer be working.