search

tinkerhubco / docnest-desktop

DocNest platform desktop app
2 stars 0 forks source link

Screen | Patient Records #10

Closed jmaicaaan closed 5 years ago

jmaicaaan commented 6 years ago
jmaicaaan commented 5 years ago

Let me know if you haven't started on this. Here's the branch https://github.com/tinker-hub/docnest-desktop/tree/feature/patient-records-screen

isotopeee commented 5 years ago

I haven't really started on this yet, It's okay if you want to take over on this task.

jmaicaaan commented 5 years ago

And here's the branch for the patient information

https://github.com/tinker-hub/docnest-desktop/tree/feature/patient-information

It is still in work in progress

isotopeee commented 5 years ago

I've renamed the feature/patient-information branch to feature/add-patient-screen-screen-ui.

jmaicaaan commented 5 years ago

1 down, one more to go! 🚀

isotopeee commented 5 years ago

I've finished working on the PatientDemographicsForm but I'm still working on the PatientMedicalForm UI. We need the latter form to be dynamic, will continue working on it tomorrow.

BTW, i've renamed the working branch to feature/patient-info-screen

isotopeee commented 5 years ago

closes #7 upon merged 🎊

jmaicaaan commented 5 years ago

I will take a look at this later

jmaicaaan commented 5 years ago

Hey @isotopeee , I cannot proceed with the review because I'm having problem installing the material chip. Npm causes some build error with node-sass. Not sure what happened.

Can you please just make sure that the functionality is working fine? We'll be needing this in a few days. We need to wrap this out this week as early as possible. Thank you.

jmaicaaan commented 5 years ago

Looks good! Can we add an expandable panel to the medical history?

isotopeee commented 5 years ago

I think when adding a new patient record, the current look/UX of the medical history form is fine. I think it's counter-intuitive when the medical history is inside an expansion panel since it might confuse the users as it looks like an optional form.

However, we can add the expansion panel in the edit view and I think it'll look great