Closed isotopeee closed 6 years ago
I'm just wondering if we could move one more level deep inside the screens
for the reason that I find it mixed properly. It is not mixed properly because at the screens
root directory, we have two root directory files - App.js
and Root.js
.
Mixing it with "screen" components is not ideal for me. Attached below is a proposal to keep. Or we could take it out of the "screens" directory (root directory files)?
Let me know your thoughts.
I see. I'll move the App.js
and Root.js
file to another directory instead of creating a subdirectory under screens
.
PR updated 🚀
Hi @isotopeee , this one looks good already to me. Do you still have pending updates? (eg: build)
Just trying to add some addons to our storybook
but I'm having network issues when installing deps. I'll ping you immediately once I'm done.
@jmaicaaan All good now 🔥
Closes #5: UI | Login Screen
Please follow the fractal pattern when structuring screens. Also, use
stateless functional components
as much as possible, it's much easier to work with functional components.