Feature/Routing and App layout

tinkerhubco / docnest-desktop

DocNest platform desktop app

2 stars 0 forks source link

Closed isotopeee closed 6 years ago

isotopeee commented 6 years ago

closes #21

I've already set up the navigation structure, Protected Routes, and created the app layout/skeleton. Sorry it took quite time ✌️

jmaicaaan commented 6 years ago

Hey @isotopeee , great work! Nothing so serious changes to be made. Tested also the electron app. Looks amazing. I like the left sidebar 🔥

Can we add a title of "Menus" there? See attached image! And also if it's not too much work. Can we add the selected menu highlighted?

Let me know your thoughts! Thanks for the work!

jmaicaaan commented 6 years ago

Oops, the menu title in the left-sidebar doesn't quite look good. Let's only add the feature for the selected menu highlighted.

Btw, how do you develop in the electron? yarn start-main-dev or start-renderer-dev seems to not working on my end.

isotopeee commented 6 years ago

Hi, @jmaicaaan. I've implemented the requested change. I start the electron app in dev mode using yarn dev.

jmaicaaan commented 6 years ago

Looks good! @isotopeee