search

tinkerhubco / docnest-desktop

DocNest platform desktop app
2 stars 0 forks source link

List of components #6

Closed jmaicaaan closed 6 years ago

jmaicaaan commented 6 years ago

Can we list down all the components we need here? Then let's have a checklist for us to add in the storybook. I plan to have it done this week.

isotopeee commented 6 years ago

I think we can add the shared components stories incrementally while building the screens. It'll be easier that way rather than be thinking of the generic style/use-cases of components at once. Regarding the shared components, I think almost all we need is included in the material-ui library. We just need to wrap it as custom components. For instance, we just have to wrap the AppBar component in our Header component. Let's maximized the usage of material-ui components as much as possible. Let me know what you think.

jmaicaaan commented 6 years ago

Doing that doesnt really make sense working with the storybook. If we are going to do that approach, the storybook shoudn't be included initially. I think that was the idea why we include the storybook. Did I missed anything?

isotopeee commented 6 years ago

I guess your right. What I have in mind right now is to wrap the material-ui components that we will need. I shall create a ticket for that.

isotopeee commented 6 years ago

I've created #8 based on our discussion. Closing this issue now.