search

tinkoff-ai / CORL

High-quality single-file implementations of SOTA Offline and Offline-to-Online RL algorithms: AWAC, BC, CQL, DT, EDAC, IQL, SAC-N, TD3+BC, LB-SAC, SPOT, Cal-QL, ReBRAC
https://arxiv.org/abs/2210.07105
Apache License 2.0
1.06k stars 124 forks source link

Add a switch to turn off wandb logging? #28

Closed levilovearch closed 1 year ago

levilovearch commented 1 year ago

Dear developers,

Thank you and Happy new year. Would you accept a PR to add an option to enable/disable wandb logging (It can certainly be enabled by default.)? The motivation is if you want to debug or dig into some algorithms, wandb logging is not necessary.

Best regards, Levi

Howuhh commented 1 year ago

Hi @levilovearch! While disabling wandb logging is a very useful feature and we use it ourselves all the time, adding a separate option seems to us like an unnecessary duplication of wandb functionality. You can already achieve desired effect with two options:

  1. write wandb disabled or wandb offline in the terminal, then if needed turn it on with wandb online
  2. set env variable WANDB_MODE=... to disabled, offline or online.

So, most simple solution would be just run WANDB_MODE=disabled python algorithms/dt.py. Additional info you can see in the wandb documentation.

levilovearch commented 1 year ago

Thank you.