tinkoff-ai / etna

ETNA – Time-Series Library
https://etna.tinkoff.ru
Apache License 2.0
856 stars 81 forks source link

Add possibility to disable logging of `etna.models.SARIMAXModel` #1305

Open Mr-Geekman opened 1 year ago

Mr-Geekman commented 1 year ago

🚀 Feature Request

Currently model etna.models.SARIMAXModel produces a lot of logs during fitting. We should give a possibility to disable it.

Proposal

Add parameter fit_params, that should accept Optional[Dict[str, Any]] = None and pass given parameters into fit in etna.models.sarimax._SARIMAXAdapter._get_fit_results.

Add in documentation that this parameter can be used to suppress logging. It can be done like this.

I don't think that this change of the signature can lead to breaking change.

Test cases

We should make sure that given parameters are passed into the model.

Additional context

No response