tinmagpie / deepdev

Deeper and deeper, where no browser has gone before...
113 stars 19 forks source link

Refactor small piece of injection. #44

Open rachelnabors opened 8 years ago

rachelnabors commented 8 years ago

Hey Potch. I took care of all this over the weekend.

But there's some cleanup I need your help with. To get my changes in ending.js to work, I had to move the following outside the IFFE statement in main.js:

`var dashboardOpen = false; // opening and closing panels in the dashboard // track open or closed

var moveDashboard = function(panel) { var $dashBoardHeight = $("#menu_options").outerHeight() + panel.outerHeight(); $("#control-panel").css({ transform: 'translateY(calc(100% - ' + $dashBoardHeight + 'px))'}); }`

Could you make that less gross: move it back into the IFFE or at least to the top of main.js. And tell me how/why so I can do it better next time!

Thanks!

potch commented 8 years ago

hmmm... looking at this.