Open NeoPolus opened 8 years ago
Hi, thanks for your extensive pull request. However, it is usually easier to implement features if they are small and contained. My reaction on these three proposals:
I really like the idea of running in a with
block! However, to make it less "automagically" as you describe it somewhere I would be in favour of the following syntax, which is more explicit about what's happening:
with Iterator(board):
...
Which is probably easiest implemented with an _is_running
attribute on the Iterator.
self.sp.read()
before passing it into ord
alltogether? Or does this problem only occur when improperly exiting?If you would like to move forward with one or more of these proposals, could you please do so in separate pull requests?
Also, please take PEP8 (https://www.python.org/dev/peps/pep-0008/) into account (use 4 spaces instead of tabs, etc.). I use flake8
to check this.
So, what's the status on this? any chance that pyFirmata will get ping support at some point?
This one would be really helpful, any chance we can provide pulse in through a special flag? without pulsein ultrasonic is not usable in firmata.
What can we do to make this PR successful?