Open or-else opened 1 year ago
Hello, is there someone working on this? if no, I am going to work on it.
Thanks!
No one is working on it. You are welcome to take a shot.
Before you start, please describe how you are going to do it:
<meta property=og:description>
, <meta property=og:image>
, <meta property=og:title>
, if these are missing then ..., then ...I am planning to proceed with these points in mind:
og:title
, og:description
, and og:image
tags for previews. If these are missing, fall back on the <title>
, meta description
, or a default image (e.g., placeholder icon).Thanks!
Perform URL fetching on the server side.
As a separate service which gets called by a client?
Please keep in mind that the server-proper does not do any message parsing right now and we do not want it to do the parsing. There is parsing in the push notifications module only. The server does not rewrite the messages and we don't want it to so.
Rendering Format: Use image-based previews with HTML templates.
Please expand on it a bit more. Also, keep in mind that the tinode clients do not have the ability to handle HTML right now and we have no plans to add such ability.
use caching
What kind of caching do you want to use?
Thanks.
ok, I will take some time on this and will update you. But if you have plan let me know.
I see two options:
The option 1 is somewhat simpler, but will encounter captcha a lot more than 2. And it would require request throttling and caching.
The option 2 is a bit more complex, because fetching and HTML parsing would have to be implemented independently for each client. And it won't just work for Javascript because of CORS: server would have to act as a proxy for requests from the JS clients.
I prefer to go with Option 1 (Server fetching, sender-client rendering). If I understand correctly, the client itself will detect the link(s) and then fetch the preview details from the server, right?
Also, would it be better for the message to wait until the server returns the preview data, or should the message text be sent immediately, with the preview appended later as an update?
Yes, the client would detect the link. It does so already.
I just checked: it looks like both Telegram and Whatsapp fetch site info while the message is being composed.
Embedded previews of URLs