tinode / ios

Tinodios: Tinode Messaging Client for iOS
Apache License 2.0
243 stars 107 forks source link

File uploading and taking photo #118

Closed YKuvonchbek closed 4 years ago

YKuvonchbek commented 4 years ago

Files don't upload (out of band). Tested on iOS 12.4.3. MessageCell for file is once display and disappear. In topic, click "+" attachment button -> "Image" -> "Take Photo" and app closed

aforge commented 4 years ago

@Kuvonchbeky Can you pull from devel branch, rebuild and run this test again please? I believe the crash when accessing the camera has been fixed. How large is the file are you trying to send as attachment?

YKuvonchbek commented 4 years ago

File size is 1.1 MB If secure connection disabled then nothing happens when try to send file

And if secure connection enabled, then app throws exception when choose file for upload:

/Users/macminidm/Desktop/Tinodios/Tinodios/LargeFileHelper.swift, line 52
2019-12-09 16:33:59.130253+0500 Tinodios[8411:188883] Fatal error: Unexpectedly found nil while unwrapping an Optional value: file /Users/macminidm/Desktop/Tinodios/Tinodios/LargeFileHelper.swift, line 52
aforge commented 4 years ago

This can happen when you aren't authenticated for some reason. I'll try to reproduce later today.

aforge commented 4 years ago

I've been able to send a file (1.5M) successfully over a secure connection. No problem at all. Can you provide instructions to reproduce please?

YKuvonchbek commented 4 years ago

I'm using: Remote server, Simulator iPhone 8 13.2.2, secure connection. I have taken up pull from devel branch. File size is 1.3 MB

Same result (crash):

File size is 1.1 MB If secure connection disabled then nothing happens when try to send file

And if secure connection enabled, then app throws exception when choose file for upload:

/Users/macminidm/Desktop/Tinodios/Tinodios/LargeFileHelper.swift, line 52
2019-12-09 16:33:59.130253+0500 Tinodios[8411:188883] Fatal error: Unexpectedly found nil while unwrapping an Optional value: file /Users/macminidm/Desktop/Tinodios/Tinodios/LargeFileHelper.swift, line 52
or-else commented 4 years ago

The crash is due to the missing authentication token. It should not crash on missing token. But if the token is missing the upload won't work even if the crash is fixed.

Do you know why you are not logged in when you upload the photo?

YKuvonchbek commented 4 years ago

The crash is due to the missing authentication token. It should not crash on missing token. But if the token is missing the upload won't work even if the crash is fixed.

Yes, auth token is nill

Do you know why you are not logged in when you upload the photo?

No, I don't know why so. But logcat shows this:

CFNetwork SSLHandshake failed (-9847)
TCP Conn 0x60000083e280 SSLHandshake failed (-9847)
[default] Tinode network error: The operation couldn’t be completed. (SwiftWebSocket.WebSocketError error 0.)
CFNetwork SSLHandshake failed (-9847)
TCP Conn 0x60000083b480 SSLHandshake failed (-9847)
[default] Tinode network error: The operation couldn’t be completed. (SwiftWebSocket.WebSocketError error 0.)
[DocumentManager] Failed to associate thumbnails for picked URL file:///Users/macminidm/Library/Developer/CoreSimulator/Devices/BE6361CD-6496-4209-9123-A57895AD8E86/data/Containers/Shared/AppGroup/4A951A7C-1858-448A-9472-6D20E8935C6A/File%20Provider%20Storage/Downloads/Snake_Wrangling_for_Kids_Learning.pdf with the Inbox copy file:///Users/macminidm/Library/Developer/CoreSimulator/Devices/BE6361CD-6496-4209-9123-A57895AD8E86/data/Containers/Data/Application/B02BCEF7-542E-4DC6-84E5-A0703B6A6C7A/tmp/co.tinode.tinodios-test-Inbox/Snake_Wrangling_for_Kids_Learning.pdf: Error Domain=QLThumbnailErrorDomain Code=102 "(null)" UserInfo={NSUnderlyingError=0x60000320ba80 {Error Domain=GSLibraryErrorDomain Code=3 "Generation not found" UserInfo={NSDescription=Generation not found}}}

before that

"...LargeFileHelper.swift, line 52"

error

or-else commented 4 years ago

Your server is likely not set up correctly. The attempt to login fails.

Can you connect to your server over https using webapp?

YKuvonchbek commented 4 years ago

Your server is likely not set up correctly. The attempt to login fails.

Can you connect to your server over https using webapp?

No, I cannot connect web client currectly, it doesn't working

or-else commented 4 years ago

So, your server is not set up correctly for https.

YKuvonchbek commented 4 years ago

Can I use iOS Client without https?

YKuvonchbek commented 4 years ago

So, your server is not set up correctly for https.

Thanks, I will correct it

or-else commented 4 years ago

Can I use iOS Client without https?

Yes.

YKuvonchbek commented 4 years ago

Thank you