tinode / ios

Tinodios: Tinode Messaging Client for iOS
Apache License 2.0
244 stars 107 forks source link

Invalid phone numbers sent to the server #20

Closed or-else closed 5 years ago

or-else commented 5 years ago

It looks like the contacts sync does not produce E.164-compliant phone numbers. The country code is missing:

query = tel:+5555648583,tel:+4155553695,tel:+5554787672,tel:+4085555270
aforge commented 5 years ago

Fixed by https://github.com/tinode/ios/commit/4cbe7cc16cb63add6e1577842937e151ef5c4859

aforge commented 5 years ago

Note however that the phone numbers on the server are stored without a +. Should we fix it as well?

or-else commented 5 years ago

The server-side issue was a data issue. It was fixes a while ago: https://github.com/tinode/chat/commit/04a2a95a3870a203c17d80bd528f76928e8c777d

The server itself does not care about format of phone numbers.