search

tinode / ios

Tinodios: Tinode Messaging Client for iOS
Apache License 2.0
243 stars 107 forks source link

Some users are missing in Find-local and New Group-members views #28

Closed or-else closed 5 years ago

or-else commented 5 years ago

iOS client shows just 4 results in Find and New Group members views while Android shows 6:

https://github.com/tinode/tindroid/blob/master/android-find-people.png https://github.com/tinode/tindroid/blob/master/android-new-topic.png

aforge commented 5 years ago

Were you logged in as alice?

or-else commented 5 years ago

Yes, as Alice.

aforge commented 5 years ago

Acknowledged. Will look into it tomorrow.

or-else commented 5 years ago

There was a similar problem on Android: some users exist in the contacts database, but some only exist as P2P conversations, like Tino.

aforge commented 5 years ago

I tried to reproduce the problem today but couldn't: the contacts lists were identical on Android and iOS. Was there anything special with your setup?

or-else commented 5 years ago

Does not seem to be anything special. Here is Android and iOS running off the same server at the same time: Simulator Screen Shot - iPhone Xʀ - 2019-05-30 at 08 29 01 Screenshot_1559230082

aforge commented 5 years ago

Okay. I cannot reproduce this with my local setup for some reason. Are you using a remote server? Or a locally built one? I've been using the docker image.

or-else commented 5 years ago

I'm building the server from source. Let me see if if I can come up with steps to reproduce.

I'm still busy with tindroid/#38

aforge commented 5 years ago

Don't worry about it then. I'll build from source too. I'll need to build the server from source soon anyway for adding push notifications.

or-else commented 5 years ago

Just hit it again: user Xena is present in contacts but does not appear in Find Simulator Screen Shot - iPhone Xʀ - 2019-07-18 at 18 03 51 Simulator Screen Shot - iPhone Xʀ - 2019-07-18 at 18 03 56

aforge commented 5 years ago

Humm.. Still can't reproduce. Is it reproducible for you? The local contacts list is read from Users table - if something's missing, we somehow fail to store a contact in the table. I'll reexamine the codepaths writing to the table.

or-else commented 5 years ago

Here are steps to reproduce:

Go to FindView, enter [basic:xena] in the search field, tap on Xena in Directory. Go to ChatList, see Xena there. Go to FindView and see that Xena is not there.

aforge commented 5 years ago

Thanks! https://github.com/tinode/ios/commit/c3a649b5e7d0e3b0d4d532a95d73a30272f08c74 should take care of it. I'm going to keep this issue open for now in case we see this behavior again.

or-else commented 5 years ago

Looks like it's fixed.