search

tinode / webapp

Tinode web chat using React
Apache License 2.0
318 stars 198 forks source link

langauge is not defined #91

Closed young310 closed 2 years ago

young310 commented 2 years ago

If you want to ask a question, please post to https://groups.google.com/d/forum/tinode instead.

Describe the bug I try to update webapp to 0.18.2 and got the error message on homepage.

To Reproduce Steps to reproduce the behavior:

  1. Go to homepage
  2. will get empty page
  3. open console
  4. See error index.js:26 Uncaught ReferenceError: langauge is not defined at index.js:26:42 at index.prod.js:1:268451

Expected behavior load the login page

Screenshots

Screen Shot 2022-03-07 at 16 37 24

Environment (please complete the following information):

Console log index.js:26 Uncaught ReferenceError: langauge is not defined at index.js:26:42 at index.prod.js:1:268451

Additional context NA

or-else commented 2 years ago

I cannot reproduce with 0.18.2:

Screenshot 2022-03-07 at 08 53 32

The error "Failed to initialize push notifications" is expected: Safari is intentionally crippled by Apple.

or-else commented 2 years ago

Use .../index-dev.html, it will give better references to errors.

young310 commented 2 years ago

@or-else I finally figure out there is a typo here https://github.com/tinode/webapp/blob/65dff7d1689b3c4b75e24c54fdae8d06328abded/umd/index.dev.js#L13504

langauge -> language

or-else commented 2 years ago

Thanks, fixed in https://github.com/tinode/webapp/commit/7e3a6169838bb1a611a0498ae7616ec6541021ae