search

tinted-theming / base16-emacs

Base16 themes for Emacs
MIT License
382 stars 76 forks source link

git changes on fringe #107

Open ratnesh1729 opened 4 years ago

ratnesh1729 commented 4 years ago

(Wanted to thank first for all the themes - this has been very useful)

fringe_old

When I have older theme - above -> please notice that the dark border on the left - this indicates git additions. (for info - this is gruvbox-dark--hard from https://github.com/greduan/emacs-theme-gruvbox/blob/master/gruvbox-dark-hard-theme.el)

With the base-16 themes here - I get it like a thin line - "please see image below" . How can I set it similar to the one above ? fringe-_base-16

Best,

ratnesh1729 commented 4 years ago

I figured this from the diff-hl github issue. I understand how the faces are set in the other theme. I do not know how the faces are set in this base-16 theme for diff-hl ? Previous commits show "diff-hl" -> but it not present in the code. https://github.com/belak/base16-emacs/search?q=diff-hl&unscoped_q=diff-hl

yunhao94 commented 4 years ago

Because your older theme specifies the diff-hl background and foreground the same color, but base16-theme only specifies the foreground color, see this and this for details.

You can either customize the background and foreground to the same color (custom-set-faces '(diff-hl-change ((t (:background "purple" :foreground "purple"))))) directly, or invert face (invert-face 'diff-hl-change) which just works for me.