tinted-theming / base16-emacs

Base16 themes for Emacs
MIT License
382 stars 76 forks source link

make the line-number-current-line inherit fringe #113

Closed paaguti closed 3 years ago

paaguti commented 3 years ago

Using the fringe for the line-number-curret-line face creates enough contrast between the current line and the rest

belak commented 3 years ago

Thanks for submitting this! Do you have before/after screenshots? It's way easier to make decisions if I can see what it's doing.

paaguti commented 3 years ago

There you are on base16-nord:

Before:

line-number-orig

After:

line-number-fringe

The line number is highlighted enough and less disturbing IMvHO

MayushKumar commented 3 years ago

I think this looks so much better. Less distracting. I think this should be provided at least as an option to toggle for those who want it.

belak commented 3 years ago

I'm sorry it's taken me so long on this - I originally wanted to leave it because I liked the original version (it's way more readable), but you're absolutely right to say this version is much less jarring.

I'm merging it as-is and if anyone complains we can look at a setting to bring back the old behavior.

Thanks!