search

tinted-theming / base16-emacs

Base16 themes for Emacs
MIT License
382 stars 77 forks source link

Added base16-shell dark and light themes #13

Closed AnthonyDiGirolamo closed 8 years ago

AnthonyDiGirolamo commented 9 years ago

Added two new themes

With these emacs will use the terminal colors rather than its own. Sourcing different base16-shell scripts should change the colors in emacs too. This was written to address issue #12.

AnthonyDiGirolamo commented 9 years ago

Suggested use would be to run source base16-atelierlakeside.dark.sh or similar in your terminal. And hava in your init.el:

(if window-system
  (load-theme 'base16-atelierlakeside-dark t)
  (load-theme 'base16-shell-dark t))

That way you get the same colors in the GUI and the terminal.

mkaito commented 9 years ago

Thank you a lot for contributing a solution! I've wrecked my head against this wall for quite a wall while.

However, I have to consider how I'll work in an extra "theme" in my workflow for merging upstream changes. Since these two themes are emacs specific (and although the vim templates also need something like this), I'm not entirely sure they should be submitted upstream. Maybe we should ask @chriskempson what he'd do about this?

AnthonyDiGirolamo commented 9 years ago

That's a good point. In vim you can set different color for when it's running in the terminal and the gui. Emacs doesn't seem to break things out for you like that. You only get one foreground and background per face. base16-shell works fine though on the terminal in vim when I set let base16colorspace=256 in the vimrc. Maybe we could have an option like that and conditionally set the colors each let block in every theme accordingly.

mkaito commented 8 years ago

@chriskempson wants to split templates into their own repo. Emacs templates will presumably end up here.

@AnthonyDiGirolamo could you turn the shell theme into a builder template and send me a PR to https://github.com/mkaito/base16-builder?

belak commented 8 years ago

This repo has gone through a pretty large reworking and this shouldn't be needed any more.

Also, the issue this fixes should be resolved in 51b0fcdce617047141eec43567aae64a9bce9f63.

belak commented 8 years ago

Looking at this more, maybe a better way of doing this would be to use the new base16 definition system but with the colors I've pulled from xresources.