search

tinted-theming / base16-emacs

Base16 themes for Emacs
MIT License
382 stars 76 forks source link

Support `orderless` faces #138

Closed kenranunderscore closed 3 months ago

kenranunderscore commented 3 months ago

Orderless completion uses 4 custom faces to highlight matches when narrowing results. Since they default to specific, fixed colors, I assigned some base16 ones.

belak commented 3 months ago

Hello! Do you have a before/after screenshot?

kenranunderscore commented 3 months ago

Sure! The faces in question are those highlighted in the minibuffer. (Sorry for the large screenshots, I felt like context was important as to why the default orderless colors don't really fit in). This is with base16-atelier-heath.

Before: 2024-04-11-083113_1916x2125_scrot

After: 2024-04-11-083020_1916x2125_scrot

kenranunderscore commented 3 months ago

@belak After using base16 colors for these faces for a week now, I saw that the readability heavily depends on the exact theme chosen (I switch between base16 themes a lot, randomly :smile:). So I made them bold, as they are bold in default orderless as well, which made it much better imho. base16-irblack:

2024-04-16-075044_2372x380_scrot

belak commented 3 months ago

One of the few times me procrastinating on merging a PR has been a good thing! Thanks for submitting this, it looks good to me!

kenranunderscore commented 3 months ago

Awesome :) And by the way, thanks for the great work with these themes! I used to try them out years ago when (IIRC) lots of faces were still missing. Now it's SO many great themes with very consistent looks!

belak commented 3 months ago

Glad you like them! Yeah, they've gotten a bunch of additional package support in the last few years, and splitting out into an org has made it easier to get new color schemes in. Definitely let us know if you find anything that's missing.