tinted-theming / base16-emacs

Base16 themes for Emacs
MIT License
382 stars 77 forks source link

adding 2 missing dark themes #33

Closed aajjbb closed 7 years ago

aajjbb commented 7 years ago

Adding missing themes I mentioned in #32

aajjbb commented 7 years ago

I know there's a bunch of other configs in the themes I'm trying to pull but as I don't know how much relevant they are to the theme, I kept them.

belak commented 7 years ago

Sorry for not being clear. When I mentioned submitting them back upstream, I meant submitting just the 16 colors to chriskempson/base16-schemes-source (or asking about them in chriskempson/base16#42).

The way themes are generated has completely changed for this project, so when the next round of scheme changes come in, these will be lost again if they're not submitted to the schemes repo. Also, if you want to temporarily add these for yourself you may want to look at how the other schemes are handled in here. It's generally much simpler.

aajjbb commented 7 years ago

Oh, that makes sense now. I'm sorry for the misunderstanding. I'll check it there and maybe pull as specified in Chris repo.

Thank you!