search

tinted-theming / base16-emacs

Base16 themes for Emacs
MIT License
380 stars 76 forks source link

Switch to using (type graphic) rather than (min-colors 256) #44

Closed belak closed 7 years ago

belak commented 7 years ago

This has the potential to fix #43 and #12. It seems to be working better without base16-shell... but it seems to really blow up with base16-shell. So, it fixes the colors in 256-color terminals if you aren't using base16-shell.

belak commented 7 years ago

The new version (so far) works properly with base16-shell and the non-256 color themes (I'm testing in iterm).

belak commented 7 years ago

Alright, in testing, this appears to work with the 256-color palate, at least for the iterm themes.

This will change how things work as it won't infer the colors any more for 256-color terminals, but I think that's fine. I'm going to merge this so people can start testing this.