Closed dstechenko closed 7 years ago
If I read the information correctly the quarantine-face was meant for syntax errors, so making it a tiny bit more noticable might be best. Other error faces have added a wavy underline, but I'm not sure if you want to go that route.
I'd like to reserve :inherit
for faces which are definitely directly related so (and please correct me if you think they are directly related) I think it may not be the best fit here.
Also, while you're in the area, could you change the heading shm to structured-haskell-mode and rearrange the section?
Thanks for taking another look at this!
The current-face
as I see it should be related to the selected region, hence that :inherit
there.
It shows the selected section in a way.
I'd like to mark quarantine-face
with something that would show that's an error, but sadly only a few colors work good as a background.
Like we could re-use highlight
, but if you try using any foreground color as a background - you start getting weird color combos in some of the themes.
Pretty much we only have base00(default), base01(highlight), base02(region) and base07(unused light background) to be safely used. base07 - works bad with some of the themes. base00 - does not show anything base02 - should be used for the selected section base01 - the only background that is left
What would be cool if we could take the error
color and make it dim a lil' (using shades of default
) and then use it to color the background.
But that's not something that aligns with base16 guidelines.
So how should we approach this? What do you think?
Fair enough. If that's the case, :inherit may make sense for current-face. Did you see the flycheck faces? Would something like that work?
Okay, it looks really good. Thanks! I will use the same styling.
One more thing to consider.
I'm thinking regarding this :inherit region
part.
We may want to switch to :inherit highlight
instead.
Due to the fact that one could try selecting some text to copy and it will overlap with the current-face
.
So I think it would be a better fit to use highlight
instead.
What do you think?
UPD.
I checked it, but seems like shm
puts current-face
over the selected region, so it's OK to use the same face anyways.
Guess we are good then.
Again, I found they use :foreground
color to mark the whole quarantined block.
Example
Which one is better, what do you think?
With :foreground
With :underline
I'm pretty much OK with both of them. I think the underline is a lil' bit better, so pushing it. But you decide, tho. :)
I prefer the underline, as it's consistent with our other error types. Thanks for your contribution!
Well, I decided to double check some of the themes after the merge #46. And turns out quarantine-face does not play nice with some of the dark ones.
What would be great is to have a warning/error color with some opacity reduced. But sadly we don't have such, so I propose to re-use highlight color.
Also use ':inherit' instead of a concrete color.
A dark theme
quarantine-fac
before:A dark theme
quarantine-face
after:A light theme
quarantine-face
after (before attached in the previous PR #46):What do you think?