Closed sonologico closed 7 years ago
Before:
After:
Minor changes. I'm using the ashes theme in this screenshot.
What are your opinions on something like :underline (:style wave :color base08)
for the error face? That lines up more with the rest of the project. Also, it seems a bit more like an error than a warning, but I may be misunderstanding something.
About the wavy line, I missed that. I like it. I'm making the change. Any comments on the color? I inherited from font-lock-warning-face, but maybe just setting it to red (base08 or base09) fits better.
Yeah, it's an error.
If it's an error, I usually stick with base08. The flycheck faces are set up how I generally do faces like this.
Squashed into a single commit. Let me know if you think other changes would make it fit in better.
Merged. Thanks for your contribution!
Thank you as well!
Can you post before and after screenshots? Thanks!
Would utop-error be better with the same wavy underline we use elsewhere for errors?