search

tinted-theming / base16-emacs

Base16 themes for Emacs
MIT License
380 stars 76 forks source link

Add tuareg and utop mode (ocaml related) faces that are not already covered #48

Closed sonologico closed 7 years ago

belak commented 7 years ago

Can you post before and after screenshots? Thanks!

Would utop-error be better with the same wavy underline we use elsewhere for errors?

sonologico commented 7 years ago

Before: before

After: after

Minor changes. I'm using the ashes theme in this screenshot.

belak commented 7 years ago

What are your opinions on something like :underline (:style wave :color base08) for the error face? That lines up more with the rest of the project. Also, it seems a bit more like an error than a warning, but I may be misunderstanding something.

sonologico commented 7 years ago

About the wavy line, I missed that. I like it. I'm making the change. Any comments on the color? I inherited from font-lock-warning-face, but maybe just setting it to red (base08 or base09) fits better.

Yeah, it's an error.

belak commented 7 years ago

If it's an error, I usually stick with base08. The flycheck faces are set up how I generally do faces like this.

sonologico commented 7 years ago

Squashed into a single commit. Let me know if you think other changes would make it fit in better.

belak commented 7 years ago

Merged. Thanks for your contribution!

sonologico commented 7 years ago

Thank you as well!