Make ansi-term-color-vector modification compatible with Emacs 24.3

tinted-theming / base16-emacs

Base16 themes for Emacs

MIT License

382 stars 77 forks source link

Make ansi-term-color-vector modification compatible with Emacs 24.3 #5

Closed fgallina closed 9 years ago

fgallina commented 11 years ago

Fixes #4

bwinterton commented 9 years ago

This would be really great if this could ever get merged in! I am experiencing the same issues, and having to change the files by hand is more effort than I am willing to put in for this theme.

subhashb commented 9 years ago

:+1: This fixed my ansi-term issue on a combo of Mac OSX Yosemite, iTerm2, GNU Emacs 25.0.50.1 and fish shell.

ghost commented 9 years ago

Shouldn't this have been a PR against chriskempson/base16-builder? Regenerating the themes for this repo from the builder will wipe out these fixes; meanwhile anyone using base16-builder directly to generate their emacs themes doesn't pick up this fix. // @chriskempson

mkaito commented 9 years ago

@toolbear yes, it should. I just checked upstream and there is no issue or pull request. @fgallina would you do that, please? It's your code, after all.