search

tinted-theming / base16-emacs

Base16 themes for Emacs
MIT License
380 stars 76 forks source link

Add magit faces #60

Closed shitikanth closed 6 years ago

shitikanth commented 6 years ago

Before: screenshot_20171202_215742

After: screenshot_20171202_215814

This is not an attempt to support all Magit faces. As @belak says in #57, there are complications, especially regarding how to handle diffs since they use different shades of red and green. The goal here is to avoid colors inconsistent with the theme as much as possible (see before pic).

belak commented 6 years ago

I think you may have meant #57. It looks pretty good to me. I also appreciate you providing screenshots. It makes it much easier to see differences and definitely helps speed up getting stuff in.

I'm not complaining, but I'm curious how you picked the colors (it's perfectly valid to say trial and error ;)). I can see (just as an example) that in the top picture names are red but in the bottom, either blue or cyan was used.

shitikanth commented 6 years ago

@belak I am not a designer, so I wouldn't have a much better answer than I picked the colors that I liked and changed the ones I didn't.

For instance, in this particular case, red was too attention-grabbing for my eyes and it was stopping from focusing on the commit messages itself, so I decided to choose a more neutral colour.

belak commented 6 years ago

That works for me. :) Thanks for your contribution!