search

tinted-theming / base16-emacs

Base16 themes for Emacs
MIT License
380 stars 76 forks source link

set the vertical border foreground color to base02 #75

Closed zonotope closed 5 years ago

zonotope commented 5 years ago

The vertical border color was previously unset in the emacs base16 theme template. This made the border between two vertically split emacs windows jarring because it was still the emacs default white color, and it didn't match any of the other theme colors.

This patch sets the vertical border foreground color to base02. If leaving out the vertical border color was intended, then please feel free to close this pull request without merging.

Thank you for maintaining the emacs port of my favorite theme.

belak commented 5 years ago

Thanks for submitting this! Could you provide either a screenshot or a way to reproduce the behavior? Thanks!

zonotope commented 5 years ago

Sure. I'm using Emacs v26.1 on Arch Linux.

Reproduction Steps:

  1. Install the base16-theme elpa package
  2. Evaluate (load-theme 'base16-eighties t) to activate
  3. Split the frame vertically with C-x 3
  4. Notice the bright border between the two windows.

Screenshots:

Original base16-eighties Emacs theme: Original base16-eighties Emacs theme

Base16-eighties with the vertical border patch applied: base16-eighties with the vertical border patch applied

belak commented 5 years ago

Ah, much appreciated! I guess I had just gotten used to that bright bar. Thanks for your contribution!

zonotope commented 5 years ago

Thank you!