search

tinted-theming / base16-emacs

Base16 themes for Emacs
MIT License
380 stars 76 forks source link

Add a few missing Magit faces #81

Closed arouanet closed 5 years ago

arouanet commented 5 years ago

Hi Kaleb,

This PR adds a few missing Magit faces.

I left the magit-diff- faces alone as they are reasonably themed by default, with a dark and light variant, unlike the ones I replaced here which were pretty straightforward. The documentation also warns that theming diff-related faces can be tricky.

Before:

screen shot 2018-11-25 at 3 03 35 pm

After:

screen shot 2018-11-25 at 3 06 20 pm
arouanet commented 5 years ago

Partially fixes #57.

belak commented 5 years ago

Sorry for the delay. Looks good to me. Thanks for getting the ball rolling on this!