Foreground base04 is unreadable on background base03 with onedark theme

[kurnevsky]

I stumbled upon this using company - company-preview has foreground base04 and company-preview-common inherited background base03. Probably there are more cases when this combination is used. So the question is - should it be allowed? If not, what the best way to fix it?

[belak]

Do you have an example of what this looks like? Screenshots or a way to reproduce that effect are the easiest way to show me what's wrong.

[kurnevsky]

Here how it looks like when there is one possible completion:

Here the suggestion has background base03 and foreground base04.

[kurnevsky]

I believe the same thing would happen with secondary-selection and docstrings. So the one way to fix it - override foreground color in secondary-selection (and region?). But I don't know how appropriate it would be. It also can be fixed for company only. If it should be fixed at all, of course. It's specific for onedark theme. For default-dark it looks like:

[kurnevsky]

ok, I think I found a good solution. There is :distant-foreground property that changes foreground only if the text is not readable. It is very convenient for selections because it changes background without touching foreground. After the fix it looks like: