Solaire mode (needs fix!)

[ema2159]

Here's the hex to rgb function and the color darkening function. I've tested them and they work correctly. I don't know how to evaluate the function in the solaire-mode section so maybe you can give me a hand, after that gets fixed, this should be ready to merge.

[belak]

I've got an experimental branch called color-darken that adds these functions and a way of "calling" them from inside the theme spec.

[ema2159]

I've been unable to use the darken color inside the color initializing function. Any idea how to?

[belak]

in place of the color, use (:darken base00 amount) where amount is how much you want it darkened

[ema2159]

Nice, now it works. Soon I'll update the Solaire mode PR

[belak]

Awesome, glad to hear it! I spent a bit of time making it relatively easy to add new functions like this in the future as well, so if any other ideas pop up I can play with them.

[ema2159]

There ya go. I also made the mode-line use base01 because base02 is too bright. And I made centaur-tabs default match solaire's background because I've been doing that consistently in all themes!

[belak]

Any chance you've got a before and after screenshot?

[ema2159]

Any chance you've got a before and after screenshot?

Yes. (The centaur-tabs background is using the darkened version in both because I can't disable it there, just ignore it) Before: After:

[belak]

Looks good! Once the quoted inheritance stuff is fixed up, I'll merge this.

[belak]

I'm going to merge in the :darken branch, which may mess with stuff, but it should clean up the diff here

[ema2159]

Looks good! Once the quoted inheritance stuff is fixed up, I'll merge this.

Sorry! I committed, but I didn't push, how about now? Recently I've been PRing the hell out in a lot of Emacs UIs repos jaja I like Emacs a lot, but I think it lacks in the UI department so I've decided to help there.

[ema2159]

@belak damn, I saw in the other PR that ther was already a color darken function so how should we proceed?